Skip to content

analytics: do not claim a twin with a Swift stdlib method #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbr merged 1 commit into from
Sep 1, 2026
Merged

analytics: do not claim a twin with a Swift stdlib method #1794

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion android/app/src/main/java/com/noop/analytics/PreSleepHeartRateFeedback.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,14 @@ object PreSleepHeartRateFeedback {
)
}

/** `a - b`, or null when it would overflow. The Long twin of Swift's `subtractingReportingOverflow`. */
/**
* `a - b`, or null when it would overflow.
*
* NOT a twin claim, though it reads like one and originally said so. Apple expresses the same
* contract with `subtractingReportingOverflow`, which is Swift STDLIB on `FixedWidthInteger` and
* therefore not a declaration in this repository at all — so a reader chasing the reference finds
* nothing, and a parity audit resolves it to nothing either.
*/
private fun subtractOrNull(a: Long, b: Long): Long? =
try { Math.subtractExact(a, b) } catch (_: ArithmeticException) { null }

Expand Down
Loading