Skip to content

Assert the widened unix as a Long (#869 follow-up) #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbr merged 1 commit into from
Aug 20, 2026
Merged

Assert the widened unix as a Long (#869 follow-up) #1484

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion android/app/src/test/java/com/noop/protocol/UnmappedHistoricalLayoutTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,11 @@ class UnmappedHistoricalLayoutTest {
@Test fun unmappedLayoutIsArchivedEvenThoughItsBytesDecodeCleanlyAsV18() {
// Precondition: read as its true version, this record decodes everything the old screen wanted.
val asV18 = decodeHistorical(bytes(whoop5V18Hex), DeviceFamily.WHOOP5)!!
assertEquals("precondition: these bytes DO decode a unix", 1780916150, asV18["unix"])
// #869 widened the decoded `unix` from Int to Long — a u32 with bit 31 set narrowed to a NEGATIVE
// Int, which the #547 plausibility gate then dropped, silently losing all history from 2038-01-19
// (and today on a future-dated strap). The value here is unchanged; only its type is wider, so the
// literal needs the L or assertEquals compares Integer against Long and fails on the box.
assertEquals("precondition: these bytes DO decode a unix", 1780916150L, asV18["unix"])
assertEquals("precondition: these bytes DO decode a heart rate", 102, asV18["heart_rate"])
assertTrue("precondition: these bytes DO decode a gravity vector", asV18["gravity_x"] is Double)

Expand Down