Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18. Broader release qualification remains tracked in #17.
Both npm consumers converted a signal-terminated native child into exit code0, so interrupted commands could be mistaken for successful work. This minimal patch preserves numeric exit codes, maps absent status to generic failure1, and waits for stream closure before returning captured output.
Frozen validation
Baseline
945fc6fc5ca2fd25ede088e6b612d8f27f670229:6/12. Candidate:12/12. Separately installed packed consumer:12/12. Unchanged corpus covers exits0/7, SIGTERM/SIGINT/SIGKILL in CLI/API,256KiB stdout/stderr and spawn EACCES. An independent reviewer reproduced all results and verified a separate delayed-descendant-output case: baseline returns empty output, candidate preserves both streams. POSIX fixture only; explicit Windows skip before setup.Run from qudag-npm:
Packed replay uses QUDAG_TEST_PACKAGE pointing at a clean installed tarball. Installation lifecycle scripts were intentionally skipped because native release assets are independently unavailable; only a harmless local executable fixture is substituted. This validates shipped JavaScript wrapper behavior, not native QuDAG functionality.
ADR207 records the stable Node completion contract, baseline, threshold and limitations. Source: https://nodejs.org/api/child_process.html#event-close (retrieved2026-09-26). Newer runtime APIs were unnecessary and would raise the existing support floor.
Existing integration fixtures27/27pass. Native npm test remains blocked by missing binary, local Rust toolchain is unconfigured, existing exact-main workflows fail, and existing elevated dependency findings require private handling. No workflow, dependency, native crypto, release, permission or promotion gate changed. Research optimization remains INCONCLUSIVE; no method improvement claimed.
Independent critique accepts only this bounded POSIX repair. Human review and all required current-head checks remain required; no merge/release/deployment is authorized by this draft.
Core Memory idempotency: dream-2026-09-26-qudag-signal-status. Federation intent686d1cae73147af27fdfbd85eecbcf2c36a35d63b719b1fd3450c68e2968d81d. Evidence will be retained in Dream Machine's2026-09-26 report.