silently discard trailing partial sample byte#100
Open
JaySon-Huang wants to merge 1 commit into
Open
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
close #63, close #81
WavReader::new()currently rejects WAV files wheredata_len % bytes_per_sample != 0, returning anError::FormatError("data chunk length is not a multiple of sample size").However, real-world audio files often have a missing final byte from truncated transfers, and mainstream players (VLC, ffmpeg, Symphonia) handle them gracefully by ignoring the trailing byte(s).
Why the change is safe
num_samplesis computed via integer division, which naturally discards the partial trailing sample.WavReaderonly usesnum_samplesfor subsequent reads — the truncateddata_lenis never referenced again.Verification
Tested against 7 real-world truncated WAV files that previously failed:
All 7 files now decode successfully with the patch, producing the expected sample counts (last partial sample silently dropped). 88 non-truncated control files continue to decode identically.