test(alias): cover non-UTF8 RC_HOST credential decoding#198
Open
overtrue wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a targeted regression test in rc-core to cover the previously-uncovered error branch where RC_HOST credentials contain syntactically valid percent-escapes that decode into invalid UTF-8 (e.g., %FF). The test asserts the error is reported as invalid percent-encoding for the secret key and that the error message does not leak credential material.
Changes:
- Add a unit test exercising non-UTF8 percent-decoded secret key handling in
parse_env_alias. - Assert the returned error message is appropriately classified and does not include access/secret credential substrings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Background
Recent RC_HOST credential parsing changes added explicit malformed percent-encoding handling. The non-UTF-8 decode error branch remained uncovered, so this PR adds a narrow regression test around that path.
Validation