(v0.9) Change rustc-abi in custom targets from x86-softfloat to softfloat#568
Open
phil-opp wants to merge 2 commits into
Open
(v0.9) Change rustc-abi in custom targets from x86-softfloat to softfloat#568phil-opp wants to merge 2 commits into
rustc-abi in custom targets from x86-softfloat to softfloat#568phil-opp wants to merge 2 commits into
Conversation
Member
Author
|
Sorry for the noise. Opened against the wrong base branch at first |
rustc-abi in custom targets from x86-softfloat to softfloat
rustc-abi in custom targets from x86-softfloat to softfloat rustc-abi in custom targets from x86-softfloat to softfloat
rustc-abi in custom targets from x86-softfloat to softfloatrustc-abi in custom targets from x86-softfloat to softfloat
rust-lang/rust#157151 removed the `x86-softfloat` compatibility alias that was introduced in rust-lang/rust#151154. Nightlies from 2026-07-05 onward reject `"rustc-abi": "x86-softfloat"` with: invalid rustc abi: 'x86-softfloat'. allowed values: 'x86-sse2', 'powerpc-spe', 'softfloat' Switch the three custom JSON target specs to the canonical `softfloat` value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
62d9e4a to
c510724
Compare
The newer nightly (>= 2026-07-05) requires `-Zunstable-options` to load custom JSON target specs. `cargo objcopy` runs an internal `rustc --target x86_64-bootloader.json --print cfg` probe (via rustc-cfg) that doesn't pass the flag and ignores RUSTFLAGS, so it fails to load the target, silently exits 0, and never produces `bootloader.bin` -- causing the later QEMU step to fail with "No such file or directory". `rust-objcopy` is the same tool from cargo-binutils but skips the target probe (we pass explicit ELF input/output paths), so it works without the flag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust PR rust-lang/rust#157151 removed the
x86-softfloatcompatibility alias. Nightlies from2026-07-05 onward reject
"rustc-abi": "x86-softfloat"with:Switch the three custom JSON target specs to the canonical
softfloatvalue.Created with Claude Code