Add CI checks with LLVM sysroot#858
Conversation
There was a problem hiding this comment.
I believe we still need the -Zcodegen-backend flag even when using the LLVM sysroot.
There was a problem hiding this comment.
I guess we'll see soon enough. :3
There was a problem hiding this comment.
Well, the test will just use cg_llvm without this, so this is not what we want.
| use_system_gcc: bool, | ||
| with_llvm_sysroot: bool, |
There was a problem hiding this comment.
I would use 1 or 2 enums here to make the caller code clearer.
There was a problem hiding this comment.
In this case, the added value is pretty minimal imo.
| run_command_with_output_and_env(&command, None, Some(&env))?; | ||
|
|
||
| args.config_info.setup(&mut env, false)?; | ||
| args.config_info.setup(&mut env, false, false)?; |
There was a problem hiding this comment.
Please add a comment to mention that we always build the sysroot with cg_gcc and we don't need to build the sysroot with cg_llvm since it's already distributed by rustup and we can just not provide --sysroot to use it.
GuillaumeGomez
force-pushed
the
llvm-sysroot
branch
2 times, most recently
from
e14606b to
3f1d43c
Compare
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
llvm-sysroot
branch
from
3f1d43c to
bebe81a
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
GuillaumeGomez
force-pushed
the
llvm-sysroot
branch
from
bebe81a to
706c60b
Compare
GuillaumeGomez
force-pushed
the
llvm-sysroot
branch
4 times, most recently
from
d6e114a to
cfc5782
Compare
GuillaumeGomez
force-pushed
the
llvm-sysroot
branch
from
cfc5782 to
fd4ab32
Compare
3 participants
Fixes #850.