Rollup of 22 pull requests#158700
Closed
JonathanBrouwer wants to merge 62 commits into
Closed
Conversation
Before mingw-w64/mingw-w64@dbfdf80 mkstemp used by Binutils was not sufficiently collision resilient and that led to CI errors for us. Our new baseline mingw-w64 toolchain's Binutils are built using mingw-w64 with the fix: niXman/mingw-builds#682 So, we should be able to get rid of it.
Add a tier 3 bare-metal target for RV32IMFC cores that have hardware single-precision floating point (the `F` extension, `ilp32f` ABI) but no atomic (`A`) extension. This is `riscv32imafc-unknown-none-elf` minus the atomic extension, handled the same way `riscv32imc-unknown-none-elf` handles a no-`a` core: `+forced-atomics` lowers atomic load/store to plain load/store (sound on a single hart) while `atomic_cas = false` keeps RMW/CAS off, so no `lr.w`/`sc.w`/`amo*` are ever emitted and the target does not trap on a core without the `A` extension. Downstream crates use a critical-section polyfill (e.g. `portable-atomic`) for compare-and-swap. This combination has no builtin target today: cores that pair a hardware-float application core with no atomic extension otherwise need a custom target spec plus `-Zbuild-std` on nightly, which is unavailable on stable. The motivating hardware is the application core of vendor SoCs such as the HiSilicon WS63/BS2X family, but the target is vendor-neutral. Register the target, add it to the `targets-elf` assembly sanity test, and document it on the shared `riscv32-unknown-none-elf` platform-support page.
In many cases where we are flattening `option::IntoIter<I>`, we can use `into_flat_iter()` instead for a simpler implementation.
This reverts commit 5fad8a6.
This tool is part of the main workspace, so its own lock file is unused, and the file is clearly outdated for its current dependencies anyway.
Splitting assembling the return value over multiple let-bindings enables pedagogic discussion of each named let-binding. The `slice` arg was renamed to remove any chance of visual confusion with use of `core::slice` functions or "slice" per se.
On platforms where `clang` defines `__int128`.
This starts with `StatementKind` and `TerminatorKind`; they don't need hashing. That then allows the removal of the `Hash` impl of various other types.
rustbot
added
A-run-make
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
Rollup of 22 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 3, 2026
…uwer Rollup of 22 pull requests Successful merges: - #155429 (Support `u128`/`i128` c-variadic arguments) - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4)) - #158494 (Improve E0277 diagnostics for conditionally implemented traits) - #158606 (use ProjectionPredicate instead of AliasRelate) - #158627 (Simplify option-iterator flattening in the compiler) - #158658 (Update LLVM submodule) - #158665 (Revert "Remove redundant dyn-compatibility check.") - #158021 (Remove old MinGW workaround) - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target) - #158549 (process::exec: using appropriate exit code on vxworks.) - #158585 (Improve diagnostic for too many super keywords) - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases) - #158651 (ptr doc: reduce use of unsafe block to where needed) - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`) - #158674 (library: Polish transmute's `split_at_stdlib` example) - #158677 (Add extra splat tests) - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes) - #158681 (Remove unnecessary `Hash` derives from MIR types) - #158682 (Avoid delayed bug for disabled on_type_error arguments) - #158684 (Add missing generic test coverage for ```#[splat]```) - #158687 (Streamline `MacEager`) - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
Member
|
@bors yield no point in waiting for the inevitable |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #158691. |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 5, 2026
…uwer Rollup of 22 pull requests Successful merges: - #155429 (Support `u128`/`i128` c-variadic arguments) - #158100 (Emit retags in codegen to support BorrowSanitizer (part 4)) - #158494 (Improve E0277 diagnostics for conditionally implemented traits) - #158606 (use ProjectionPredicate instead of AliasRelate) - #158627 (Simplify option-iterator flattening in the compiler) - #158658 (Update LLVM submodule) - #158665 (Revert "Remove redundant dyn-compatibility check.") - #158021 (Remove old MinGW workaround) - #158473 (Add `riscv32imfc-unknown-none-elf` bare-metal target) - #158549 (process::exec: using appropriate exit code on vxworks.) - #158585 (Improve diagnostic for too many super keywords) - #158637 (hir_ty_lowering: avoid self type lookup for inherent aliases) - #158651 (ptr doc: reduce use of unsafe block to where needed) - #158669 (Remove `src/tools/test-float-parse/Cargo.lock`) - #158674 (library: Polish transmute's `split_at_stdlib` example) - #158677 (Add extra splat tests) - #158680 (Avoid ICE for `NonZero<char>` in improper_ctypes) - #158681 (Remove unnecessary `Hash` derives from MIR types) - #158682 (Avoid delayed bug for disabled on_type_error arguments) - #158684 (Add missing generic test coverage for ```#[splat]```) - #158687 (Streamline `MacEager`) - #158688 (Cleanup attribute docs and add links to other mentioned attributes)
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 535b10b failed: CI. Failed job:
|
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #155429, which is a member of this rollup, was unapproved. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
u128/i128c-variadic arguments #155429 (Supportu128/i128c-variadic arguments)riscv32imfc-unknown-none-elfbare-metal target #158473 (Addriscv32imfc-unknown-none-elfbare-metal target)src/tools/test-float-parse/Cargo.lock#158669 (Removesrc/tools/test-float-parse/Cargo.lock)split_at_stdlibexample #158674 (library: Polish transmute'ssplit_at_stdlibexample)NonZero<char>in improper_ctypes #158680 (Avoid ICE forNonZero<char>in improper_ctypes)Hashderives from MIR types #158681 (Remove unnecessaryHashderives from MIR types)#[splat]#158684 (Add missing generic test coverage for#[splat])MacEager#158687 (StreamlineMacEager)r? @ghost
Create a similar rollup