delegation: support mapping of all arguments with Self type#158690
Draft
aerooneqq wants to merge 4 commits into
Draft
delegation: support mapping of all arguments with Self type#158690aerooneqq wants to merge 4 commits into
Self type#158690aerooneqq wants to merge 4 commits into
Conversation
rustbot
added
S-waiting-on-author
Contributor
Author
rustbot
added
S-blocked
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports applying target expression to arguments of
Selftype.That the first part of this feature which touches AST -> HIR lowering only and allows lowering of delegation's block several tumes when there are no definitions inside.
The second part will adjust typeck so we can apply adjustments to all mapped arguments as to the first argument of delegation. This should also eventually weak the condition of argument mapping allowing
Box<Self>,Arc<Self>, etc.Part of #118212.
r? @petrochenkov