Disable f128 support on wasm#158672
Closed
ChrisDenton wants to merge 1 commit into
Closed
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
Seems reasonable, but r? @alexcrichton |
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
@bors r- We shouldn't use the intrinsic on wasm if it's broken, LLVM has had some problems bringing those up. Please don't disable it unconditionally since it's otherwise working and getting tested. |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Contributor
|
Also, please ping me for any f16/f128 PRs since there are some subtleties still floating around |
Member
Author
|
Ah, ok. I'll close this since it isn't the right approach. |
rustbot
removed
the
S-waiting-on-author
Contributor
|
I'll try to get a PR together for this (edit: none needed, see #158673 (comment)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #150075 (comment) for the motivation.