view-types: store view types in the AST

[scrabsha]

View all comments

Tracking issue: #155938.

Instead of discarding view types, we store them in the AST now!

[JonathanBrouwer]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 9d3dea7 (9d3dea74651f758e35177070e510be8f3639a7fd, parent: 6769f690f947f12e36db6b6503bab265b7b2cced)

[rust-timer]

Finished benchmarking commit (9d3dea7): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-1.4%, -0.3%]	6
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.1%]	2
All ❌✅ (primary)	-0.7%	[-1.4%, -0.3%]	6

Max RSS (memory usage)

Results (primary 0.1%, secondary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-0.8%	[-0.8%, -0.7%]	2
Improvements ✅ (secondary)	-4.4%	[-7.3%, -1.5%]	2
All ❌✅ (primary)	0.1%	[-0.8%, 1.9%]	3

Cycles

Results (secondary 3.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.0%	[0.5%, 9.9%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.3%	[-1.3%, -1.3%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 503.61s -> 496.571s (-1.40%)
Artifact size: 394.46 MiB -> 394.47 MiB (0.00%)

[scrabsha]

^

• rebased to main to fix conflicts
• fixed view-types: store view types in the AST #156016 (comment)

r? nikomatsakis

[mejrs]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: da11554 (da11554295c5a399af4126d879abc5ccffc090a8)
Base parent: c397dae (c397dae808f70caebab1fc4e11b3edf7e59f58c7)

[oli-obk]

[rust-bors]

📌 Commit dcdf133 has been approved by oli-obk

It is now in the queue for this repository.

[rust-bors]

⚠️ A new commit 3ed5f56b7d381af42cd7a460a777cd5ea500af85 was pushed.

This pull request was unapproved.

Auto build was cancelled due to push. Cancelled workflows:

• https://github.com/rust-lang/rust/actions/runs/28851160777

[oli-obk]

@bors r+

[rust-bors]

📌 Commit 3ed5f56 has been approved by oli-obk

It is now in the queue for this repository.

[rust-bors]

💔 Test for 75770e7 failed: CI. Failed job:

• auto - aarch64-apple-macos-26 (web logs, enhanced plaintext logs)

[rust-log-analyzer]

The job aarch64-apple-macos-26 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Important

For more information how to resolve CI failures of this job, visit this link.

[JonathanBrouwer]

@bors retry