Update the cc crate for rustc_llvm#155438
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
Given that the previous attempt regressed performance: @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Update the cc crate for rustc_llvm
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (f61a781): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.0%, secondary 2.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 490.301s -> 492.119s (0.37%) |
|
I think we need an explanation if not necessarily a solution (though those regressions look rather large, including on full builds). @rustbot author |
Update a bunch of dependencies to reduce windows-sys duplication This gets rid of windows-sys 0.60 and with the exception of curl and stacker it gets rid of windows-sys 0.59. For stacker getting rid of windows-sys 0.59 is blocked on rust-lang/stacker#145 and #155438.
|
The nearest to an explanation seems to be #146186 (comment), cc @madsmtm It would be a bit of a problem if we can never upgrade cc-rs again... |
|
I never got further than that investigation unfortunately |
Update a bunch of dependencies to reduce windows-sys duplication This gets rid of windows-sys 0.60 and with the exception of curl and stacker it gets rid of windows-sys 0.59. For stacker getting rid of windows-sys 0.59 is blocked on rust-lang/stacker#145 and rust-lang/rust#155438.
Update a bunch of dependencies to reduce windows-sys duplication This gets rid of windows-sys 0.60 and with the exception of curl and stacker it gets rid of windows-sys 0.59. For stacker getting rid of windows-sys 0.59 is blocked on rust-lang/stacker#145 and rust-lang/rust#155438.
Update a bunch of dependencies to reduce windows-sys duplication This gets rid of windows-sys 0.60 and with the exception of curl and stacker it gets rid of windows-sys 0.59. For stacker getting rid of windows-sys 0.59 is blocked on rust-lang/stacker#145 and rust-lang/rust#155438.
|
I've ran cachegrind for stm32f4-0.15.1 and I'm now fairly certain that #146186 (comment) was correct about jemalloc being the cause of the slowdown. Cachegrind shows a lot more jemalloc functions after this PR, suggesting less inlining. |
|
Pushed a commit to use the first cc release containing rust-lang/cc-rs#1424. @bors try @rust-timer queue |
Unless I'm mistaken, Previously, any dependency of ours that was using I think the most straightforward way to get this back is possibly to pass That said, doing so could have the side effect of turning on LTO for other parts of the build (as most systems that build C will pick these up, even if they don't parse/translate rustflags, which most don't), which may be a good thing, but also could cause further problems. |
|
The code I modified is the code that determines the CFLAGS and CXXFLAGS env vars that will be passed to cargo build. |
|
Looks like the code I modified effectively gets ignored in the end: #t-infra/bootstrap > weird code in fill_target_compiler @ 💬 |
This comment has been minimized.
This comment has been minimized.
Latest stacker needs a newer cc than 1.2.16 as older versions don't have windows arm64ec support.
Latest stacker needs a newer cc than 1.2.16 as older versions don't have windows arm64ec support.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
This comment has been minimized.
This comment has been minimized.
Update the cc crate for rustc_llvm
|
💔 Test for 983a800 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
@bors try @rust-timer queue |
|
This pull request is already queued and waiting for a try build to finish. |
This comment has been minimized.
This comment has been minimized.
Update the cc crate for rustc_llvm
|
💔 Test for 5852e40 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Fix typo Extracted out of rust-lang#155438
Fix typo Extracted out of rust-lang#155438
View all comments
Latest stacker needs a newer cc than 1.2.16 as older versions don't have windows arm64ec support.