Implement clamp_min and clamp_max by Kyuuhachi · Pull Request #147786 · rust-lang/rust

Kyuuhachi · 2025-10-16T18:42:59Z

Implements #147781.

rustbot · 2025-10-16T18:43:05Z

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kyuuhachi · 2025-10-22T18:23:13Z

Oops. Silly copypaste mistakes.

Kyuuhachi · 2025-10-23T12:23:43Z

@rustbot ready

joboet · 2025-10-30T19:41:56Z

r=me after squashing commits

@bors delegate+

bors · 2025-10-30T19:41:59Z

✌️ @Kyuuhachi, you can now approve this pull request!

If @joboet told you to "r=me" after making some further change, please make that change, then do @bors r=@joboet

Add example clamping by length Implement clamp_min/max on floats Fix copypaste mistakes in tests

rustbot · 2025-10-31T19:00:52Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Kyuuhachi · 2025-10-31T19:03:03Z

@bors r=@joboet

bors · 2025-10-31T19:03:06Z

📌 Commit af5b798 has been approved by joboet

It is now in the queue for this repository.

Implement clamp_min and clamp_max Implements rust-lang#147781.

Zalathar · 2025-11-01T07:27:42Z

Failed in rollup in test-various: #148354 (comment)

@bors r-

matthiaskrgr · 2025-11-01T07:27:48Z

@bors r- #148354 (comment)

bors · 2025-12-01T21:35:21Z

☔ The latest upstream changes (presumably #149510) made this pull request unmergeable. Please resolve the merge conflicts.

Kyuuhachi · 2025-12-16T22:32:02Z

Closing as superseded by #150075.

Implement clamp_to Implements the revised version of #147781. Supersedes #147786. Currently I restrict the ClampBounds trait using a second, perma-unstable feature. I don't know if that's the usual way to deal with this kind of traits, I'd be happy to change it if not. ~~I currently define NaN as equal to no bound. This is consistent with `max` and `min`, but is inconsistent with `clamp`, which panics.~~ Changed so that the float versions panic if any bound is NaN, just like `clamp` does.

…,ChrisDenton Implement clamp_to Implements the revised version of rust-lang#147781. Supersedes rust-lang#147786. Currently I restrict the ClampBounds trait using a second, perma-unstable feature. I don't know if that's the usual way to deal with this kind of traits, I'd be happy to change it if not. ~~I currently define NaN as equal to no bound. This is consistent with `max` and `min`, but is inconsistent with `clamp`, which panics.~~ Changed so that the float versions panic if any bound is NaN, just like `clamp` does.

Implement clamp_to Implements the revised version of #147781. Supersedes #147786. Currently I restrict the ClampBounds trait using a second, perma-unstable feature. I don't know if that's the usual way to deal with this kind of traits, I'd be happy to change it if not. ~~I currently define NaN as equal to no bound. This is consistent with `max` and `min`, but is inconsistent with `clamp`, which panics.~~ Changed so that the float versions panic if any bound is NaN, just like `clamp` does.

…,ChrisDenton Implement clamp_to Implements the revised version of rust-lang#147781. Supersedes rust-lang#147786. Currently I restrict the ClampBounds trait using a second, perma-unstable feature. I don't know if that's the usual way to deal with this kind of traits, I'd be happy to change it if not. ~~I currently define NaN as equal to no bound. This is consistent with `max` and `min`, but is inconsistent with `clamp`, which panics.~~ Changed so that the float versions panic if any bound is NaN, just like `clamp` does.

rustbot assigned joboet Oct 16, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 16, 2025

Kyuuhachi mentioned this pull request Oct 16, 2025

Tracking Issue for clamp_to #147781

Open

5 tasks

joboet requested changes Oct 21, 2025

View reviewed changes

Comment thread library/core/src/num/f64.rs Outdated

Comment thread library/core/src/num/f32.rs Outdated

Comment thread library/core/src/num/f16.rs Outdated

Comment thread library/core/src/num/f128.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2025

joboet approved these changes Oct 30, 2025

View reviewed changes

Add Ord::clamp_min and clamp_max

af5b798

Add example clamping by length Implement clamp_min/max on floats Fix copypaste mistakes in tests

Kyuuhachi force-pushed the clamp-min-max branch from 525fbce to af5b798 Compare October 31, 2025 19:00

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025

Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet

f284588

Implement clamp_min and clamp_max Implements rust-lang#147781.

Zalathar mentioned this pull request Nov 1, 2025

Rollup of 19 pull requests #148351

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025

Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet

48ee427

Implement clamp_min and clamp_max Implements rust-lang#147781.

Zalathar mentioned this pull request Nov 1, 2025

Rollup of 19 pull requests #148354

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025

Rollup merge of rust-lang#147786 - Kyuuhachi:clamp-min-max, r=joboet

5effb6e

Implement clamp_min and clamp_max Implements rust-lang#147781.

matthiaskrgr mentioned this pull request Nov 1, 2025

Rollup of 11 pull requests #148355

Closed

bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 1, 2025

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2025

Kyuuhachi mentioned this pull request Dec 16, 2025

Implement clamp_to #150075

Open

Kyuuhachi closed this Dec 16, 2025

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 16, 2025

Uh oh!

Uh oh!

Conversation

Kyuuhachi commented Oct 16, 2025

Uh oh!

rustbot commented Oct 16, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Kyuuhachi commented Oct 22, 2025

Uh oh!

Kyuuhachi commented Oct 23, 2025

Uh oh!

joboet commented Oct 30, 2025

Uh oh!

bors commented Oct 30, 2025

Uh oh!

rustbot commented Oct 31, 2025

Uh oh!

Kyuuhachi commented Oct 31, 2025

Uh oh!

bors commented Oct 31, 2025

Uh oh!

Zalathar commented Nov 1, 2025

Uh oh!

matthiaskrgr commented Nov 1, 2025

Uh oh!

bors commented Dec 1, 2025

Uh oh!

Kyuuhachi commented Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants