Implement IntoIterator for [&[mut]] Box<[T; N], A>

[WaffleLapkin]

View all comments

Revival of #124108

[bors]

☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts.

[WaffleLapkin]

@scottmcm anything I can do to move this forward?

[Mark-Simulacrum]

I guess this also needs rebasing + FCP, maybe starting with the FCP makes sense since it's not obvious to me this is worth it (especially if it needs an edition change...)

View changes since this review

[rust-rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[programmerjake]

@WaffleLapkin I assume you mean it can be merged as-is?
I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.
cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

I have published a new release to crates.io (0.5.1) with the pull request merged that should resolve the issue.

unfortunately that was an incomplete fix: https://github.com/WhyAreAllTheseTaken/static-array/pull/1/changes#r3461196266
the PR missed at least one other a_boxed_array.into_iter() call.

[WaffleLapkin]

@WaffleLapkin I assume you mean it can be merged as-is?

@BurntSushi yes, that is what I meant 🤦🏻

[WhyAreAllTheseTaken]

@WaffleLapkin I assume you mean it can be merged as-is?
I agree it isn't used much. It does have one dependent though that seems to be active. So I think we should be cautious here.
cc @WhyAreAllTheseTaken see WhyAreAllTheseTaken/static-array#1

I have published a new release to crates.io (0.5.1) with the pull request merged that should resolve the issue.

unfortunately that was an incomplete fix: https://github.com/WhyAreAllTheseTaken/static-array/pull/1/changes#r3461196266 the PR missed at least one other a_boxed_array.into_iter() call.

static-array 0.5.2 is now released which includes WhyAreAllTheseTaken/static-array#3 which should fix the issue.

[Mark-Simulacrum]

@bors squash msg="Implement IntoIterator for [&[mut]] Box<[T; N], A>"

[rust-bors]

🔨 6 commits were squashed into 8842949.

[programmerjake]

squashing gave a broken commit message, so I think you'll want to manually git commit --amend it.

(reported the bug here)

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[Mark-Simulacrum]

@bors r+ rollup=iffy

[rust-bors]

📋 This PR cannot be approved because it currently has the following label: final-comment-period.

[Mark-Simulacrum]

Ah, I guess not quite ready, but r=me once the FCP elapses in ~5 days.

[rust-rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

[Mark-Simulacrum]

@bors r+

[rust-bors]

📌 Commit 5b4299f has been approved by Mark-Simulacrum

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.