Skip to content

//@ needs-matching-clang is misleading #126180

Description

@Zalathar

Via #126155, I discovered that the //@ needs-matching-clang compiletest header is a lot more strict than one might assume from its name.

Tests with this header are not run by default, regardless of whether a “matching clang” is available or not. Instead, they only run if environment variable RUSTBUILD_FORCE_CLANG_BASED_TESTS is set.

The only test job that sets this variable is x86_64-gnu-debug, but that job currently doesn't actually run any tests! (Though that might change as a result of #126155.)

@rustbot label +A-compiletest +A-testsuite

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions