Skip to content

Rustup#3893

Merged
bors merged 20 commits into
rust-lang:masterfrom
mati865:rustup
Mar 18, 2019
Merged

Rustup#3893
bors merged 20 commits into
rust-lang:masterfrom
mati865:rustup

Conversation

@mati865

@mati865 mati865 commented Mar 18, 2019

Copy link
Copy Markdown
Member

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

@mati865 mati865 mentioned this pull request Mar 18, 2019
@oli-obk

oli-obk commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 8cfc91b has been approved by oli-obk

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8cfc91b with merge 4895097...

@mati865

mati865 commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

Formatting with --all this time...

@bors retry

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

@mati865: 🔑 Insufficient privileges: not in try users

@oli-obk

oli-obk commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

📌 Commit 6cb0605 has been approved by oli-obk

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6cb0605 with merge a7e0c0b...

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@matthiaskrgr

Copy link
Copy Markdown
Member
  Installing /Users/travis/.cargo/bin/rustup-toolchain-install-master
detecting the channel of the `cd45b19bd2d8b4f9a3940a409ea43285019f3280` toolchain...
error: https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rustc-builds/cd45b19bd2d8b4f9a3940a409ea43285019f3280/rust-src-nightly.tar.xz: timed out
error: toolchain 'master' is not installed
info: backtrace:
stack backtrace:
   0:        0x10cd8bf8e - backtrace::backtrace::trace::hb39615e846d97438
   1:        0x10cd8b1a4 - error_chain::backtrace::imp::InternalBacktrace::new::h42957417422586b4
   2:        0x10c9ebcc1 - rustup_init::rustup_mode::main::ha2b3dbc277471d62
   3:        0x10ca27c4c - rustup_init::run_rustup::he197b959e963ea85
   4:        0x10ca26f87 - rustup_init::main::h9d7da49ccb0c8cc2
   5:        0x10c9cddc5 - std::rt::lang_start::{{closure}}::h11a539400a49a543
   6:        0x10ca2cc68 - _main

@bors retry

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6cb0605 with merge 849ac1d...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

💥 Test timed out

@matthiaskrgr

Copy link
Copy Markdown
Member

@bors retry

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6cb0605 with merge 6a0a197...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@mati865

mati865 commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

@flip1995

Copy link
Copy Markdown
Member

@bors retry p=10

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit 6cb0605 with merge 92612c9...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@Xanewok

Xanewok commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

Please let me know if/when you decide to update tools in the Rust tree - I'd like to update to the current RLS master (which also means pulling in Rustfmt 1.1) in tandem with this.

@mati865

mati865 commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

@Xanewok you can upgrade all the tools in Rust repo at same time if you want.

@bors

bors commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 92612c9 to master...

@bors bors merged commit 6cb0605 into rust-lang:master Mar 18, 2019
@mati865 mati865 deleted the rustup branch March 18, 2019 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants