fix: parse doc link with turbofish generics - #23334
Open
dimxy wants to merge 1 commit into
Open
Conversation
Refactor doc link mod path parsing code.
dimxy
marked this pull request as ready for review
September 9, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors doc_modpath_from_str fn marked with "FIXME" and fixes parsing of links with turbofish.
There are a few issues with the existing function:
"S::<i32>::f"is parsed asModPath { kind: Plain, segments: [Name { symbol: "S", ctx: () }, Name { symbol: "", ctx: () }, Name { symbol: "f", ctx: () }] }(extra empty "symbol" in the middle) and cannot be navigated in r-a GUI.The proposed solution:
impl ast::Type { fn parse(..) }similar to existing ast::Expr.Disclaimer: Claude Code was used to help with code analysis, reviewing changes and suggesting tests.