internal: Remove the interner/db argument from empty() and default_types() - #23325
Open
ChayimFriedman2 wants to merge 1 commit into
Open
internal: Remove the interner/db argument from empty() and default_types()#23325ChayimFriedman2 wants to merge 1 commit into
empty() and default_types()#23325ChayimFriedman2 wants to merge 1 commit into
Conversation
Interning doesn't really need an interner since the types are global. Initially I wanted to remove *all* `DbInterner` arguments from constructors, however: 1. This is a *much* larger change. 2. We want to eventually move the types under rustc_type_ir. Then having our own constructors will need extension traits and not be comfortable, and the inherent constructors will require an interner (because rustc needs it). However empty lists do not need an interner even in rustc. Pre-interned types (`default_types()`) do, but this will likely remain under our control, and also the version without interner is a tiny bit more efficient, because the `OnceLock` closure doesn't have captures.
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interning doesn't really need an interner since the types are global. Initially I wanted to remove all
DbInternerarguments from constructors, however:default_types()) do, but this will likely remain under our control, and also the version without interner is a tiny bit more efficient, because theOnceLockclosure doesn't have captures.Essentially implements what I suggested in #23196 (comment), CC @Veykril.