Fix Remote::get_refspec() lifetime bounds and add regression tests#1287
Open
DanielEScherzer wants to merge 1 commit into
Open
Fix Remote::get_refspec() lifetime bounds and add regression tests#1287DanielEScherzer wants to merge 1 commit into
Remote::get_refspec() lifetime bounds and add regression tests#1287DanielEScherzer wants to merge 1 commit into
Conversation
Set up testing with the `trybuild` crate so that we can confirm that the problematic code no longer compiles. I tried to add the regression test in a separate commit, but the problematic code compiled earlier (so `compile_fail()` could not be used) but did not run successfully (exit code 139 due to the use after free, so `pass()` could not be used either). Fixes rust-lang#1286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set up testing with the
trybuildcrate so that we can confirm that the problematic code no longer compiles. I tried to add the regression test in a separate commit, but the problematic code compiled earlier (socompile_fail()could not be used) but did not run successfully (exit code 139 due to the use after free, sopass()could not be used either).Fixes #1286