Batch mergeability checks on base branch pushes#744
Conversation
There was a problem hiding this comment.
I'm really sorry that it took me so long to take a look at this, I didn't have much time for reviews in the past 2-3 months.
The implementation looks great! I tested it on a live repository and it seems to work as expected, it would be cool to get rid of the thousands useless GH API requests to reload the mergeability of all open PRs.
I left some comments regarding the implementation. I haven't looked at the failing tests yet.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Thank you! Sorry, I was on a vacation last week. The changes look good, I now also went through the tests, and found that there is one ~obsolete test that we don't need anymore after this change. I also rebased over |
|
Looks like it does! I'll merge it now to test this on the staging environment. Thanks a lot for working on this! |
|
I tested this on staging and it looks good! I'll probably deploy it to production today to see how it behaves with ~1100 open PRs 😅 |
3 participants
Closes #707