Feat/build teacher form - #129
Open
AdelObaji11 wants to merge 4 commits into
Open
AdelObaji11 wants to merge 4 commits into
AdelObaji11 wants to merge 4 commits into
Conversation
M0aZzZ
reviewed
Sep 22, 2026
| lastName: teacherData.lastName, | ||
| email: teacherData.email, | ||
| phoneNumber: teacherData.phoneNumber, | ||
| hashedPassword: teacherData.password, |
Contributor
There was a problem hiding this comment.
hashedPassword should not be populated from the raw password on the frontend. The frontend should send the plain password field to the API, and password hashing should remain a backend responsibility.
| } | ||
|
|
||
| return ( | ||
| <div className="fixed inset-0 z-50 flex items-center justify-center bg-black/40"> |
Contributor
There was a problem hiding this comment.
This modal is implemented manually while the project already uses the shared Dialog component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.