Repository navigation
feat: implement search filtering for devtools composable inspectors - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
payload.filterin thegetInspectorTreehook — but the plugin's handler (packages/plugin/src/vue/devtools/index.ts) ignored it entirely, so typing in the search box had no effect on any of the three composable inspectors.filterTree, which recursively filters a built tree by matching nodelabel(case-insensitively): a node is kept if it matches directly (in which case all of its children are kept too, for context) or if any of its descendants match (in which case only the matching descendants are kept).filterTreeintogetInspectorTreesopayload.filteris applied to the tree before it's sent to DevTools, and added atreeFilterPlaceholderto each inspector so the search box hints at what can be searched.Closes #27
Test plan
pnpm vitest run packages/pluginpasses (added unit tests forfilterTree)pnpm lintpassespnpm plugin:buildsucceeds