Feat: hello world example - #3
Merged
Merged
Conversation
brosenpod
reviewed
Nov 17, 2025
|
|
||
| # Scaling behavior is controlled by configuration passed to the `CpuLiveServerless` class. | ||
| # Here, we'll define several variables that change the default behavior of our serverless endpoint. | ||
| # `workersMin` sets our endpoint to scale to 0 active containers; `workersMax` will allow our endpoint |
There was a problem hiding this comment.
Very nitpicky, but this comment wraps at 102 characters, and the one on line 12 doesn't wrap and is 123 characters.
Contributor
Author
There was a problem hiding this comment.
👍 probably time to have an actual strategy for comment wrapping, instead of the mad max approach
Member
|
@jhcipar I've thought about keeping the first example to its simplest form, and that we should just focus on having a GPU worker. This way, we can have a separate one just for CPU worker. The rest would go like:
|
deanq
requested changes
Nov 17, 2025
deanq
left a comment
deanq
left a comment
Member
There was a problem hiding this comment.
Let's focus on GPU workers to keep the first example small. See my comment in general. Also the general 01 readme https://github.com/runpod/flash-examples/tree/main/01_getting_started
jhcipar
force-pushed
the
jhcipar/alpha-flash-examples-01
branch
from
November 17, 2025 20:27
3f46613 to
9235dde
Compare
jhcipar
force-pushed
the
jhcipar/alpha-flash-examples-01
branch
from
November 17, 2025 20:31
9235dde to
db2d60b
Compare
deanq
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the first runnable Flash example under 01_getting_started/01_hello_world, giving both CPU and GPU worker implementations plus a simple entrypoint.
It adds a .flashignore tailored for the example’s artifacts, a
main.pythat spins up the example with routing and matching worker packages (workers/cpu and workers/gpu) with stub init.pys and concrete endpoint.py handlers so developers can see parallel CPU/GPU patterns side by side.