fix: preserve falsy metadata values in Azure AI Search vector store#21388
Open
voidborne-d wants to merge 1 commit intorun-llama:mainfrom
Open
fix: preserve falsy metadata values in Azure AI Search vector store#21388voidborne-d wants to merge 1 commit intorun-llama:mainfrom
voidborne-d wants to merge 1 commit intorun-llama:mainfrom
Conversation
The truthiness check `if metadata_value:` silently drops valid falsy values like 0, "", [], and False when building the index document. Replace with an explicit `is not None` check so that only truly absent keys are skipped. Fixes run-llama#21385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Falsy metadata values (
0,"",[],False) are silently dropped when building the Azure AI Search index document.The current truthiness check on line 899:
skips any value that evaluates to
Falsein a boolean context, which includes valid values like integer0, empty strings, and empty lists.Fix
Replace the truthiness check with an explicit
Nonecheck:This ensures only truly absent metadata keys are skipped, while all valid falsy values are preserved in the index.
Reproducing
0Noneinstead of0Fixes #21385