fix(vllm): filter None kwargs before passing to SamplingParams#21375
Open
andreafresa wants to merge 1 commit intorun-llama:mainfrom
Open
fix(vllm): filter None kwargs before passing to SamplingParams#21375andreafresa wants to merge 1 commit intorun-llama:mainfrom
andreafresa wants to merge 1 commit intorun-llama:mainfrom
Conversation
vLLM >= 0.19.0 removed `best_of` from SamplingParams. Since `_model_kwargs`
unconditionally included it, every `.complete()` call raised:
TypeError: Unexpected keyword argument 'best_of'
Filter out None-valued keys so removed or unset parameters are never
forwarded to SamplingParams, making the integration robust to future
vLLM API changes.
Fixes run-llama#21371
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21371
llama-index-llms-vllmhardcodesbest_ofin_model_kwargs, but vLLM >= 0.19.0 removedbest_offromSamplingParams. Since_model_kwargsunconditionally included it, every.complete()call raised:Root cause —
base.pyline 257:Fix — filter out
None-valued keys before returning:This way any parameter whose default is
None(includingbest_of) is simply omitted, making the integration robust to future vLLM API removals without breaking explicitly set values.Test plan
Vllm.complete()no longer raisesTypeErrorwith vLLM >= 0.19.0temperature=0.7) are still forwarded correctlybest_ofis still forwarded when explicitly set to a non-None value (for older vLLM versions)