fix(mcp): handle EmbeddedResource, AudioContent, and ResourceLink in get_prompt#21364
Open
Yanhu007 wants to merge 1 commit intorun-llama:mainfrom
Open
fix(mcp): handle EmbeddedResource, AudioContent, and ResourceLink in get_prompt#21364Yanhu007 wants to merge 1 commit intorun-llama:mainfrom
Yanhu007 wants to merge 1 commit intorun-llama:mainfrom
Conversation
…get_prompt get_prompt() raises NotImplementedError for EmbeddedResource and ValueError for other valid MCP ContentBlock variants (AudioContent, ResourceLink). Any MCP server returning these spec-valid types causes the method to crash. - EmbeddedResource: extract text from TextResourceContents, fall back to URI description for BlobResourceContents - AudioContent: convert to LlamaIndex AudioBlock - ResourceLink: convert to TextBlock with URI - Unknown types: warn and fall back to text representation instead of raising ValueError Fixes run-llama#21270
dosubot
bot
added
the
size:M
Contributor
|
hello @Yanhu007, issue author here tysm for working on this :) there is a PR already open on this #21271 I took a brief overview of the code, and one major bug i'd say with this implementation is that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21270
BasicMCPClient.get_prompt()currently only handlesTextContentandImageContent. It raisesNotImplementedErrorforEmbeddedResourceandValueErrorfor other valid MCPContentBlockvariants. Any MCP server returning these spec-valid types causes a crash.Changes
EmbeddedResource(text)NotImplementedErrorTextBlockEmbeddedResource(blob)NotImplementedErrorTextBlockAudioContentValueErrorAudioBlockResourceLinkValueErrorTextBlockValueError(crash)Key Design Decisions
EmbeddedResourcewithTextResourceContentsextracts the actual text contentAudioContentmaps directly to LlamaIndex'sAudioBlockhasattr(types, ...)guards for types that may not exist in older MCP SDK versions