feat(confluence-reader): add default parser framework and release 0.8.0#21357
Open
tysonite wants to merge 3 commits intorun-llama:mainfrom
Open
feat(confluence-reader): add default parser framework and release 0.8.0#21357tysonite wants to merge 3 commits intorun-llama:mainfrom
tysonite wants to merge 3 commits intorun-llama:mainfrom
Conversation
- Introduce a new default parser module and route both page HTML and attachments through a unified CustomParserManager pipeline - Expand FileType coverage with PAGE_HTML, XLSB, MSG, and SVG, and export FileType from the package init - Always initialize CustomParserManager, merge built-in parsers with user overrides, and allow custom_folder without requiring custom_parsers - Move heavy parser dependencies into an all optional extra, keep core dependencies lean, and update lockfile/dependency layout - Improve processing behavior by enforcing fail_on_error for attachments, adding page-id-aware error logs, and preserving parser metadata while keeping default metadata keys authoritative - Remove legacy html_parser module and update tests, README, and CHANGELOG for new parser architecture and usage patterns
… Python 3.10 and 3.11 Import override from typing_extensions instead of typing so the package works on Python versions before 3.12, and add the runtime dependency in pyproject.toml.
Contributor
Author
|
@logan-markewich I would appreciate it if you could find some time to review and upstream these changes. They are mostly refactoring. I have already tested them in my corporate project and plan to contribute a few more updates (e.g., comments parsing, PDF page parsing in addition to HTML, and some further cleanups). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backward incompatible changes
llama-index-readers-confluencealso installed all attachment-parsing dependencies (pytesseract, pdf2image, Pillow, docx2txt, python-pptx, pandas, openpyxl, pyxlsb, extract-msg, beautifulsoup4, svglib, reportlab) as core dependencies. Usinginclude_attachments=Trueinload_data()worked without any additional install steps. As of 0.8.0, these dependencies have been moved out of the core package and into the [all] optional extra. Callers who useinclude_attachments=Truemust now install:pip install "llama-index-readers-confluence[all]". Without [all], callingload_data(..., include_attachments=True)will raiseImportError(or silently produce empty attachment text, depending on which file type is encountered) because the underlying parser libraries are no longer present.New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods