fix(pdf-reader): prevent local Path casting for remote s3 URIs to fix crash#21353
Open
spideyashith wants to merge 1 commit intorun-llama:mainfrom
Open
fix(pdf-reader): prevent local Path casting for remote s3 URIs to fix crash#21353spideyashith wants to merge 1 commit intorun-llama:mainfrom
spideyashith wants to merge 1 commit intorun-llama:mainfrom
Conversation
Author
|
"Hi @logan-markewich , I've implemented the fix for the S3 Path casting crash. Could you please approve the CI workflows to run? I've verified the fix locally on Windows." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where
PDFReaderforcefully casts remote cloud URIs (likes3://) into localPathobjects, which strips the URI formatting and crashes the reader.Fixes:
Pathcasting if thefilevariable is a remote URI string.Pathobject or a string.Fixes #15406
New Package?
Version Bump?
Type of Change
How Has This Been Tested?
Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods