Repository navigation
Add settings checkbox(es) for removing context menu items for link and selected text #157
Description
Installing various add-ons can easily clutter up the context menu, even if some items are just present when text is selected.
Please add a checkbox as: [x] Show context menu item for selected text. You can keep the current default.
I think, when the following already present checkbox is checked: [x] Automatically use the text selected on the website, the new checkbox should be disabled and unchecked.
Activity
rugk commentedon Jan 8, 2019
You know that one only sees the context menu item if text is selected and/or if you click on a link?
So it's at least not shown for all cases.
And thus, IMHO, quite discrete…
That said, I would be fine with such a checkbox (enabled by default, as you said). (PRs appreciated…)
I am not fine with automatically disabling/modifying it when another option is changed though. The correlation between the settings may not obvious to the user and there are valid use-cases for having both settings enabled.
shanirub commentedon Jul 4, 2019
Hi there, I would like to work on this issue.
The task as i understand it includes the following steps:
As a beginner i would love to get some feedback:
Did i forget anything? Any advice?
Thanks.
rugk commentedon Jul 4, 2019
Hi @shanirub ,
great, yes, feel free to take this issue. 😃
shanirub commentedon Jul 22, 2019
options.htmlContextMenu.jsDefaultSettings.jsc3ho commentedon Oct 3, 2019
Hi, I noticed this hasn't been updated since July 22. May I work on the issue?
I'm a first time contributor, so please bear with me.
rugk commentedon Oct 3, 2019
@shanirub already did some work on this, as it seems. So let's wait for a reply here.
Having a quick look at the fork, the changes are apparently in the master branch here: https://github.com/shanirub/offline-qr-code/commits/master (not reviewed!)
So assigning @shanirub for getting a reply whether @c3ho can/should take over this change or not?
shanirub commentedon Oct 3, 2019
@rugk I would very much like to continue working on this issue.
@c3ho sorry.
jn64 commentedon Oct 31, 2019
Hope to see this feature, because Firefox default access key for Inspect Element is also Q.
Alternatively allow changing the access key for this addon to R
rugk commentedon Oct 31, 2019
For simplicity reasons, we'd only want to have one fixed and value and it should be a word that is included in the context menu text. In any case, however, your underlying issue seems to be valid/a good point, so please open a new issue for that. (As it may be fixed independently to this one, as you've noticed by yourself.)
rugk commentedon Oct 31, 2019
@shanirub If you need any pointers/help or have questions, feel free to ask.
16 remaining items
starborne-nova commentedon Feb 22, 2022
log2022-2-21_21-46-22.txt
I've managed to integrate an option for disabling the context menu, however I haven't been able to make the context menu appear at all. Was hoping I could get some help figuring out what I am doing wrong. I've attached the console log from trying to get it to work.
And here's the changes I've made so far
https://github.com/starborne-nova/offline-qr-code/commit/c95a4deedb30f8fb0fcd520a37af611b525b6759
rugk commentedon Feb 27, 2022
@starborne-nova From having a quick look the code changes all looks fine? Did you make sure to clone the repo with submodules or check them out afterwards?
In any case, I'd appreciate a PR, so the option can be integrated.
deepak-158 commentedon Oct 12, 2024
\assign
rugk commentedon Oct 16, 2024
Okay and thanks @deepak-158, I'll assign you.
Everyone contributing to this though please take care not to do work that has already be done:
From previous contributors the PR #257 looks quite far/promising and I've already commented/reviewed missing things there. You can just…
You may need to change the origin of the branches or so or pull/push it to a different one while doing so, so the changes you want are in there. You can always open a draft PR though to see what's going on.
If you are unsure and confused by these complicated lingo/wild terms and need to dig into some git knowledge, there are plenty of resources online. https://learngitbranching.js.org/ is e.g. a good interactive guide.
artfulrobot commentedon Jun 11, 2026
Um, I came here to report this problem: the context menu binds to Q, which is already bound to "Inspect" - a feature I rely on heavily in my workflow:
Being able to change the bound key, or simply not choosing a key which conflicts with core Firefox in the first place, would be great. However, I'd be happy with disabling it in the context menu, as per this issue, and the merged PR at #336 (comment) suggests that this option should be present, but I'm using v 1.9 and I can't see that option present in the Preferences page.
So I'm confused.
TL;DR:
rugk commentedon Jun 19, 2026
Yeah sorry, this is fixed in the dev version, (I just merged #358 to fix a subsequent related issue) just not yet released. I'll prepare a release.
rugk commentedon Jun 19, 2026
Ah just noticed your screenshot, note though on special elements like links and so on, it is always shown currently. For now, you can just press
Qmultiple times to choose between the context menu entries.rugk commentedon Jun 19, 2026
So I'll reopen and clarify the issue to be about the other non-generic extensions. It should be an easy addition, if someone wants to add it.
[-]Add settings checkbox for removing context menu item[/-][+]Add settings checkbox(es) for removing context menu items for link and selected text[/+]