Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Can be considered a follow-up to #453.
I did again some profiling and noted that a lot of time was still spent in
unescape. The main problem is that the doublegsubwill allocate two copies of the string to the potential third copy when the encoding was not UTF-8. This is solved by combining the two regex into one. as only theUCHARcontains capture groups, it is clear within the block ofgsubwhich one to replace.The second optimization is to add a
match?for an early return. Now this means theUNESCAPE_COMBINEDregex is executed twice when encountering a match, but since most things parsed won't contain these special cases, the early return will have a positive benefit for most parsing operations.Benchmark script:
Results: