Add new Rails/InGroupsOf cop - #1654
Open
jcoleman wants to merge 1 commit into
Open
Conversation
Prefer Ruby's built-in `Enumerable#each_slice` over Active Support's `in_groups_of` when the collection is chunked without an intentional fill value. Calling `in_groups_of` without a second argument pads the final group with `nil`, which is easy to overlook and frequently leads to a NoMethodError on nil (or another type error) downstream. The cop reports calls with no second argument and calls passing an explicit `false` (which is equivalent to `each_slice`). Any other explicit second argument is treated as an intentional fill value and left alone. An `explicit` EnforcedStyle instead asks for an explicit second argument on calls that omit one, making the padding behavior obvious at the call site; in that style any explicit second argument, including `false`, is accepted. Autocorrection is not supported because an omitted second argument may reflect an intentional desire to pad with `nil` rather than a bug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jcoleman
force-pushed
the
rails-in-groups-of-cop
branch
from
August 20, 2026 14:23
12e8784 to
4a3e06c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prefer Ruby's built-in
Enumerable#each_sliceover Active Support'sin_groups_ofwhen the collection is chunked without an intentional fill value.The cop reports calls with no second argument and calls passing an explicit
false(which is equivalent toeach_slice). Any other explicit second argument is treated as an intentional fill value and left alone.An
explicitEnforcedStyle instead asks for an explicit second argument on calls that omit one, making the padding behavior obvious at the call site; in that style any explicit second argument, includingfalse, is accepted.Autocorrection is not supported because an omitted second argument may reflect an intentional desire to pad with
nilrather than a bug.Why
We've noticed that it's
in_groups_ofis a common source of bugs. Callingin_groups_ofwithout a second argument pads the final group withnil, which is easy to overlook and frequently leads to a NoMethodError on nil (or another type error) downstream.While
in_groups_ofis useful in e.g. HTML table generation (where padding is likely the default requirement), the now-builtin Rubyeach_sliceis semantically more correct by default for most code we've seen.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.