[Fix #532] Fix false negatives for Performance/ChainArrayAllocation - #533
Merged
koic merged 1 commit intoAug 11, 2026
Merged
Conversation
…cation` `flat_map`, `filter_map`, and `collect_concat` always return a new array, but they were missing from `ALWAYS_RETURNS_NEW_ARRAY`, so a chain built on them was only partially matched or not matched at all. `nodes.flat_map(&:file_ids).compact.uniq` reported one offense while the same-shaped `map` version reported two, and rewriting a flagged chain around `flat_map` silenced the cop without fixing the allocation it complained about. Recognize the three methods as chain receivers. They are not added to `HAS_MUTATION_ALTERNATIVE` because no bang variants exist, so they are never suggested for `!` conversion. Fixes rubocop#532.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flat_map,filter_map, andcollect_concatalways return a new array, but they were missing fromALWAYS_RETURNS_NEW_ARRAY, so a chain built on them was only partially matched or not matched at all.nodes.flat_map(&:file_ids).compact.uniqreported one offense while the same-shapedmapversion reported two, and rewriting a flagged chain aroundflat_mapsilenced the cop without fixing the allocation it complained about.Recognize the three methods as chain receivers. They are not added to
HAS_MUTATION_ALTERNATIVEbecause no bang variants exist, so they are never suggested for!conversion.Fixes #532.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.