[Fix #438] Fix an incorrect autocorrect for Performance/ConstantRegex… - #529
Open
pcbeingused333 wants to merge 1 commit into
Open
[Fix #438] Fix an incorrect autocorrect for Performance/ConstantRegex…#529pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…ntRegexp in pattern matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p in pattern matching
Fixes #438.
Performance/ConstantRegexpautocorrects an interpolated-constant regexp by appending the/ooption. When the regexp is used as a pattern in pattern matching (case/in, one-linein),/ois invalid Ruby and the autocorrection produces broken code (NODE_ONCE: unknown node).This skips registering an offense when the regexp is in a pattern-matching pattern position, mirroring the existing
within_allowed_assignment?guard. Added specs for thecase/inand one-lineinforms.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.