[Fix #510] Clarify Performance/RegexpMatch message for !~ - #528
Merged
koic merged 1 commit intoAug 11, 2026
Merged
Conversation
The offense message said to use `match?` instead of `!~`, but following that wording literally when correcting by hand negates the logic of the expression. Prefix the suggested method with `!` for `!~`, in the same way as `Performance/StringInclude` does, so that the message guides manual corrections that preserve behavior. The autocorrection was already correct and is unchanged. Fixes rubocop#510.
koic
force-pushed
the
fix_regexp_match_offense_message_for_bang_tilde
branch
from
July 14, 2026 12:57
744fa30 to
f1763dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The offense message said to use
match?instead of!~, but following that wording literally when correcting by hand negates the logic of the expression. Prefix the suggested method with!for!~, in the same way asPerformance/StringIncludedoes, so that the message guides manual corrections that preserve behavior. The autocorrection was already correct and is unchanged.Fixes #510.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.