Repository navigation
ci: open an issue when the weekly integration run fails - #77
Merged
Merged
Conversation
security.yml keeps the same title, labels, and issue text.
The issue closes on the next green run, like the security audit issue.
jfk.wav no longer exists; the PCM is committed under test/support/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
.github/workflows/integration.ymlatmainends with one step. Nothing reports a failed weekly run, so it shows only as a GitHub e-mail.The fixture cache in
.github/actions/setup/action.ymllists a file that no longer exists, and misses the VAD model:Problem
The integration run exists to catch upstream model and audio rot within a week. A failure opens no issue, so nobody hears of it.
security.ymlalready opens and closes an issue, but its 50 lines of JS live inline in that workflow.After
The new composite action
.github/actions/report-failureholds the JS.security.ymlandintegration.ymlboth call it. On failure it opens or comments on the issueIntegration Tests Failed(labelsintegration,automated). On the next green run it comments and closes the issue.The dispatch run on this branch is green, and the resolve step ran without an error: https://github.com/rubas/whisper_cpp/actions/runs/38914300860
The fixture cache now saves the VAD model, and its key changes when
test/support/fixtures.exchanges:security.ymlpasses the same title, labels, and issue text as before. This is the diff of the moved JS, from the two steps ofsecurity.ymlatmainto the action (whitespace ignored):Details
Cause.
.github/workflows/integration.yml:jobs.integrationhas noif: failure()step..github/actions/setup/action.ymlstepCache integration fixturesstill liststest/fixtures/jfk.wav, which moved totest/support/, and missestest/fixtures/ggml-silero-v5.1.2.bin, whichtest/support/fixtures.exdownloads.Design. One composite action instead of a second copy of the JS. It takes
result(failureorsuccess),title,subject, andlabels(a JSON array of{name, color, description}).subjectkeeps the issue text ofsecurity.ymlword for word ("The security audit failed on ...", "Security audit passed. Closing."). All inputs reach the script throughenv:, so zizmor finds no template injection.actions/github-scriptstays pinned to3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9.0.0. The integration job getsissues: write.Tests.
zizmor --offline --persona=pedantic .github/workflows .github/actions/report-failure: "No findings to report".actionlint1.7.12 reports only findings thatmainalready has: it does not know the same-repositoryuses: $/...syntax, and SC2209 on the existingMIX_ENV=test mix hex.auditline.githubclient covered four cases: failure with an open issue (creates the missing label, comments), failure without an issue (creates it with labels), success (comments and closes), and a badresult(throws).$/action ref on GitHub.