Repository navigation
release: 0.5.0 - #69
Merged
Merged
Conversation
Owner
Author
|
Review findings, checked against the tree. Fixes are in 4183374. Opus
Astra
Gate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 0.5.0 of
whisper_cpp.Why this release
cudaartefacts carry kernels for the ggml release GPU list, not onlysm_52PTX.:invalid_request([P3] Pcm.slice raises instead of returning invalid_request for very large times #53, [P3] Three accepted inputs raise at the NIF boundary instead of returning invalid_request #54, [P3] The short-slice path does not apply the full native request contract #55).Transcription.languageis always the ISO code ([P3] An empty result reports the requested language name instead of the ISO code #52). Native error messages lose thekind=tag ([P3] Native error messages still carry the internal kind= routing tag #48). Word timestamps work for scripts without spaces ([P3] word_timestamps returns one word per segment for scripts without spaces #51). 1 to 40 samples with auto-detect return an empty result ([P3] Audio shorter than 41 samples returns an error when the language is auto-detected #66). Build variables recompile the wrapper ([P2] Backend build tasks do not recompile the NIF wrapper when the selection changes #46), and an unpublishedWHISPER_CPP_VARIANTfails the compile ([P3] An unavailable variant silently falls back to the default artefact #49).Several changes are caller-visible, so this is a minor bump.
CHANGELOG.mdnames the action for each one.Included PRs
Issue #26 stays open: whisper-rs upstream has no release with the trampoline fix.
Changes in this PR
mix.exs:@version0.4.1 -> 0.5.0.CHANGELOG.md: the 0.5.0 entry. It replaces the[Unreleased]CI entry, which named Elixir 1.20.3 and OTP 29.0.5; CI now uses 1.20.4 and 29.1.1.README.md: install snippet~> 0.5.0, and the CPU baseline note says "from 0.5.0 on".0.1.0).Risks for the release run
GGML_NATIVE=OFF(ci: build releases from the tag, pin a CPU baseline, add job timeouts #63) also run for the first time. The CUDA jobs take longer and the tarballs grow.nif_known_language/1withnif_resolve_language/2, so 0.5.0 needs new artefacts on every target. A missing tarball fails the install on that target.After the merge, follow the AGENTS.md Release steps: wait for
release.yml, regeneratechecksum-Elixir.WhisperCpp.Native.exs, push it, thenmix hex.publish.Dependencies
mix hex.outdated: every Hex dependency is up to date.cargo update --dry-run: 0 packages to update.Checks
WHISPER_CPP_BUILD=1 task check: green. Format, compile with warnings as errors,credo --strict(no issues), ExUnit 62 passed and 22 excluded, cargo tests 33 passed, zizmor no findings.WHISPER_CPP_BUILD=1 task test:integration(ggml-tiny.enandggml-tiny): 84 passed.dprint.jsonin this repository, so nodprint fmt.