Skip to content

Headers informing logic integration - #651

Open
julia-zack wants to merge 15 commits into
masterfrom
headers-informing-logic-integration
Open

Headers informing logic integration#651
julia-zack wants to merge 15 commits into
masterfrom
headers-informing-logic-integration

Remove unnecessary mock and rename depth to height

9ab366b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jul 24, 2026 in 46s

Quality Gate passed

Issues
96 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 4218 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgFE7cx6K3rA1r81&open=AZ-PlgFE7cx6K3rA1r81&pullRequest=651

Check warning on line 122 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgBv7cx6K3rA1r8N&open=AZ-PlgBv7cx6K3rA1r8N&pullRequest=651

Check warning on line 2231 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "doReturn". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgD37cx6K3rA1r8o&open=AZ-PlgD37cx6K3rA1r8o&pullRequest=651

Check warning on line 265 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgD37cx6K3rA1r8k&open=AZ-PlgD37cx6K3rA1r8k&pullRequest=651

Check warning on line 87 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf777cx6K3rA1r7k&open=AZ-Plf777cx6K3rA1r7k&pullRequest=651

Check warning on line 132 in src/test/java/co/rsk/federate/signing/hsm/client/PowHSMSigningClientRskMstTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgCG7cx6K3rA1r8S&open=AZ-PlgCG7cx6K3rA1r8S&pullRequest=651

Check warning on line 491 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgFE7cx6K3rA1r8p&open=AZ-PlgFE7cx6K3rA1r8p&pullRequest=651

Check warning on line 564 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce the total number of break and continue statements in this loop to use at most one. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf_S7cx6K3rA1r74&open=AZ-Plf_S7cx6K3rA1r74&pullRequest=651

Check failure on line 601 in src/main/java/co/rsk/federate/BtcToRskClient.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if/for/while/switch/try statements. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf_S7cx6K3rA1r73&open=AZ-Plf_S7cx6K3rA1r73&pullRequest=651

Check warning on line 4338 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgFE7cx6K3rA1r85&open=AZ-PlgFE7cx6K3rA1r85&pullRequest=651

Check warning on line 119 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf777cx6K3rA1r7o&open=AZ-Plf777cx6K3rA1r7o&pullRequest=651

Check warning on line 270 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgA-7cx6K3rA1r8I&open=AZ-PlgA-7cx6K3rA1r8I&pullRequest=651

Check warning on line 149 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgC97cx6K3rA1r8W&open=AZ-PlgC97cx6K3rA1r8W&pullRequest=651

Check warning on line 148 in src/main/java/co/rsk/federate/PegUtils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Either log or rethrow this exception. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf9c7cx6K3rA1r7z&open=AZ-Plf9c7cx6K3rA1r7z&pullRequest=651

Check warning on line 221 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgC97cx6K3rA1r8a&open=AZ-PlgC97cx6K3rA1r8a&pullRequest=651

Check warning on line 261 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgD37cx6K3rA1r8j&open=AZ-PlgD37cx6K3rA1r8j&pullRequest=651

Check warning on line 206 in src/test/java/co/rsk/federate/signing/ECDSAHSMSignerTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgC97cx6K3rA1r8Z&open=AZ-PlgC97cx6K3rA1r8Z&pullRequest=651

Check warning on line 146 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf777cx6K3rA1r7w&open=AZ-Plf777cx6K3rA1r7w&pullRequest=651

Check warning on line 4193 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgFE7cx6K3rA1r80&open=AZ-PlgFE7cx6K3rA1r80&pullRequest=651

Check warning on line 135 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgD37cx6K3rA1r8d&open=AZ-PlgD37cx6K3rA1r8d&pullRequest=651

Check warning on line 176 in src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "times". 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgD37cx6K3rA1r8e&open=AZ-PlgD37cx6K3rA1r8e&pullRequest=651

Check warning on line 80 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf777cx6K3rA1r7i&open=AZ-Plf777cx6K3rA1r7i&pullRequest=651

Check warning on line 220 in src/test/java/co/rsk/federate/signing/hsm/client/HSMSigningClientV1Test.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use assertThrows() instead of try/catch and fail() in the try block. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgA-7cx6K3rA1r8F&open=AZ-PlgA-7cx6K3rA1r8F&pullRequest=651

Check warning on line 94 in src/main/java/co/rsk/federate/util/HSMChecker.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of System.out by a logger. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-Plf777cx6K3rA1r7l&open=AZ-Plf777cx6K3rA1r7l&pullRequest=651

Check warning on line 742 in src/test/java/co/rsk/federate/BtcToRskClientTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename "federatorSupport" which hides the field declared at line 67. 

See more on https://sonarcloud.io/project/issues?id=rsksmart_powpeg-node&issues=AZ-PlgFE7cx6K3rA1r8q&open=AZ-PlgFE7cx6K3rA1r8q&pullRequest=651
View more details on SonarQubeCloud