[WIP] - build: point at testnet4-aware bitcoinj / bitcoinj-thin - #632
Closed
jeremy-then wants to merge 2 commits into
Closed
[WIP] - build: point at testnet4-aware bitcoinj / bitcoinj-thin#632jeremy-then wants to merge 2 commits into
jeremy-then wants to merge 2 commits into
Conversation
Bump bitcoinj-core to 0.15.6-rsk-6 and bitcoinj-thin to 0.14.4-rsk-19 so the federator's SPV wallet and the embedded bridge understand Bitcoin testnet4. powpeg needs no code change for testnet4 — the federation is already built as segwit P2SH-P2WSH-ERP.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Collaborator
|
Replaced by #654 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dependency-only change: bump bitcoinj-core to
0.15.6-rsk-6and bitcoinj-thin to0.14.4-rsk-19(plus the matching
verification-metadata.xmlentries). Those versions add the Bitcoin testnet4network parameters, which the federator needs on both sides:
No powpeg code change is required for testnet4, the federator already builds its federation as a
segwit P2SH-P2WSH-ERP federation, which is exactly what the testnet2 genesis federation uses.
Motivation and Context
RSK is introducing a testnet2 network whose peg is backed by Bitcoin testnet4 (BIP-94, the successor
to testnet3). For a federator to operate that peg it must understand testnet4 (network magic, genesis,
BIP-94 difficulty rules) on both its SPV wallet and the embedded bridge. This PR pulls in that support via
the dependency bump. Companion PRs:
rsksmart/rskjrsksmart/bitcoinj—0.15.6-rsk-6rsksmart/bitcoinj-thin—0.14.4-rsk-19How Has This Been Tested?
Built the full stack locally (composite build: powpeg-node + rskj + the testnet4-aware bitcoinj/bitcoinj-thin)
and ran a single self-mined federator on testnet2 against a real, fully-synced Bitcoin testnet4 node
(
bitcoindv31). Exercised the federator-specific paths end-to-end:testnet4 header chain (BIP-94) with no verification errors.
BtcToRskClientdetected a deposit to the federation, built the SPV proof, and relayed it viaregisterBtcTransaction; the bridge credited RBTC 1:1.BtcReleaseClientsigned the segwit (P2SH-P2WSH-ERP) release with the BIP-143 sighash andbroadcast it to testnet4; the confirmed release's change output was re-registered to the federation.
(~143,800 headers) with zero verification failures.
Note: this is a dependency bump with no powpeg code change, so no new unit tests were added; validation was
end-to-end/integration as above.
Types of changes
Checklist:
Other information:
🚧 WIP / Draft — blocked on dependency releases. This branch references bitcoinj
0.15.6-rsk-6andbitcoinj-thin
0.14.4-rsk-19, which are not published yet (pending review + security review + taggedrelease of the companion PRs). Until they are published, CI will fail to resolve the dependencies —
expected. Once released, this branch builds as-is.
gradle/verification-metadata.xmluses trust rules for the two unpublished artifacts; they should betightened to checksummed
<component>entries once the artifacts are published.scope here and handled by ops — powpeg needs no code change for testnet4.