Repository navigation
Reject non-string JSON values when decoding IDs - #125
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Updates JSON ID decoding to reject non-string values while preserving null handling.
Changes:
- Validate JSON string delimiters before decoding.
- Add regression tests for numeric and array inputs.
File summaries
| File | Description |
|---|---|
id.go |
Enforces JSON string input for IDs. |
id_test.go |
Tests rejection of invalid JSON values. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #124, which was accidentally closed and its source fork deleted. The implementation is unchanged; the original discussion and reviews remain linked there.
json.Unmarshalaccepts certain numbers and arrays as IDs becauseUnmarshalJSONstrips the first and last byte without checking for quotes. For example, both1111111111111111111101and[11111111111111111110]decode successfully to the ID11111111111111111110.Require a JSON string before delegating to
UnmarshalText, retaining the existing null handling and short-input guard. Regression tests exercise both valid JSON inputs throughencoding/jsonand verify that rejection leaves the receiver unchanged.Validation: both cases fail before the fix.
go test -race -cover ./...passes (94.3% main-package coverage),go vet ./...passes, and staticcheck passes with tests disabled. Full staticcheck reports the pre-existing unused error assignment inid_test.go:153.