Skip to content

Code for parsing derived predicates - #28

Merged
rpgoldman merged 3 commits into
masterfrom
27-handle-derived-predicates
Jun 19, 2026
Merged

rpgoldman merged 3 commits into
masterfrom
27-handle-derived-predicates

Conversation

@rpgoldman

Copy link
Copy Markdown
Owner

Add domain-derived-predicates, derived-predicate-name, derived-predicate-params and derived-predicate-def.

Fixes #27

rpgoldman added 2 commits June 4, 2026 19:31
We can now handle the requirement of :derived-predicates.

This code was substantially generated by Opencode with Qwopus, with
edits and corrections from me.
@rpgoldman rpgoldman linked an issue Jun 5, 2026 that may be closed by this pull request
@rpgoldman rpgoldman self-assigned this Jun 5, 2026
@rpgoldman
rpgoldman requested a review from mpatsift June 5, 2026 23:17
@mpatsift

Copy link
Copy Markdown
Collaborator

Looks good and works for my case! I suggest adding derived keyword arg and handling to make-domain.

I will make a suggestion.

@mpatsift

Copy link
Copy Markdown
Collaborator

There's a design decision about whether make-domain callers should include derived predicate declarations w :predicates. I decided "yes", but up to you! This way seems closer to what pddl users are used to.

@mpatsift mpatsift left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved per comments in the pull request.

@rpgoldman

Copy link
Copy Markdown
Owner Author

There's a design decision about whether make-domain callers should include derived predicate declarations w :predicates. I decided "yes", but up to you! This way seems closer to what pddl users are used to.

The funny thing is that SHOP domains don’t require you to declare predicates at all….

@rpgoldman

Copy link
Copy Markdown
Owner Author

Looks good and works for my case! I suggest adding derived keyword arg and handling to make-domain.

I will make a suggestion.

What about adding a keyword arg that is :pddl-requirements? If that was supplied we could set the appropriate class for the domain based on requirements. We’d have to use ensure-class, though.

@mpatsift

Copy link
Copy Markdown
Collaborator

Is that more of a shop3 issue? In this case, there is a :requirements arg and the domain representation is a list.

@rpgoldman

Copy link
Copy Markdown
Owner Author

Is that more of a shop3 issue? In this case, there is a :requirements arg and the domain representation is a list.

Sorry: you are right. I was in the wrong mental context when I wrote that comment.

@mpatsift

Copy link
Copy Markdown
Collaborator

Whenever you have a chance to look over my changes to make-domain and canonicalize-domain, this is ready to merge.

@rpgoldman

Copy link
Copy Markdown
Owner Author

If we get a chance, we should add a test for make-domain. Other than that, looks great. I will merge.

@rpgoldman
rpgoldman merged commit bed0c4e into master Jun 19, 2026
3 checks passed
@rpgoldman
rpgoldman deleted the 27-handle-derived-predicates branch June 19, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle :derived predicates

2 participants