Repository navigation
fix(plugins): respect semantic release precedence - #515
Open
Ricardo-M-L wants to merge 1 commit into
Open
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the core updater's existing SemVer comparison for plugin release tags. An installed
2.0.0-rc.1currently treats GitHub's latest stable1.9.0as an available update; changes only to build metadata also incorrectly enable the update action.The comparator is extracted into a shared service without changing core-update behavior. Plugin tags that are not SemVer, including short dotted versions and arbitrary release names, retain their existing fallback behavior. No dependencies or UI layout changes.
Regression coverage
2.0.0-rc.1versus latest1.9.0, verifyingupdateAvailable: falsethrough the actual plugin refresh path.Before the fix, six comparison assertions fail on the unchanged base. After the fix, all 41 core/plugin tests pass.
Validation
bun test tests/versionManagement.test.ts tests/plugins.test.ts— 41 passed.bun run check— passed.bun run build— passed.bun test— 946 passed, 32 skipped, 4 failed. A pristine worktree at base1d5198ereproduces the same four failures (937 passed, 32 skipped, 4 failed): UI localization boundaries, the OAuth quota priority card, normalization of a string priority, and the shared-notice role exception list. None of those files are changed here.I also checked the open version-picker PR #488: it retains the existing non-dotted-tag comparison, so this fixes a separate precedence issue.