Skip to content

fix(ui): stabilize notices, settings refresh and page scrolling - #509

Merged
github-actions[bot] merged 1 commit into
router-for-me:miaomiaofrom
Roomen:fix/ui-feedback-stability
Oct 23, 2026
Merged

github-actions[bot] merged 1 commit into
router-for-me:miaomiaofrom
Roomen:fix/ui-feedback-stability

Conversation

@Roomen

@Roomen Roomen commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep dismiss buttons beside wrapped notice text instead of moving them to a new row.
  • Preserve Advanced Features controls and unsaved drafts during configuration watcher refreshes.
  • Remove the legacy Usage tab hover fill and keep scrolling inside the workspace, including compact window layouts.
  • Add regression coverage for refresh stability, notice geometry, tab hover styles and scrolling boundaries.

Validation

  • bun run check: passed.
  • bun test tests/cssSyntax.test.ts tests/cssLayers.test.ts tests/cssThemeLint.test.ts: 51 passed.
  • PLAYWRIGHT_MODULE="$(npm root -g)/playwright" node tests/ui-feedback-stability-ui.cjs: 30 scenarios passed across Chromium and WebKit. Restoring the original notice and hover bugs made the regression test fail.
  • PLAYWRIGHT_MODULE="$(npm root -g)/playwright" node tests/config-topnav-ui.cjs: 4 scenarios passed (2 viewports × 2 locales).
  • Existing failures reproduced on the unchanged baseline: stateControls.test.tsx has 6 passes and 1 role-exception failure; operation-feedback-ui.cjs times out waiting for the pricing table; responsive-layout-ui.cjs times out waiting for the quota heading.
  • Full test suite, Rust tests and native desktop validation were not run. Native macOS elastic scrolling still needs manual verification; headless WebKit does not validate the native window material. The Agents browser mock reaches an existing error boundary and is not counted as UI coverage.

Screenshots

Browser mock (?mock=running), with synthetic sample data. The wrapped notice is rendered through the shared notification component for the screenshot.

Usage tabs while hovering Analysis:

Usage tabs

Wrapped notice with its dismiss button on the right:

Wrapped notice

- Keep wrapped notice dismiss controls beside their messages
- Preserve settings controls and drafts during background refreshes
- Align usage tab hover styles with shared navigation
- Contain page scrolling within the workspace at all window sizes

Validation: typecheck; 51 CSS tests; 30 Chromium/WebKit scenarios; 4 shared-tab scenarios
@github-actions
github-actions Bot merged commit 4c8bc89 into router-for-me:miaomiao Oct 23, 2026
9 checks passed
@github-actions

Copy link
Copy Markdown

已自动合并并发布 Miaomiao Preview。

构建提交:4c8bc89966dd0aac2a71820134a877986b0e2cec

下载页为滚动预览版,后续成功构建会替换安装包。

@Roomen
Roomen deleted the fix/ui-feedback-stability branch October 23, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant