Skip to content

fix(config): align advanced settings header with shared tabs - #506

Merged
github-actions[bot] merged 1 commit into
router-for-me:miaomiaofrom
Roomen:fix/advanced-settings-header
Oct 22, 2026
Merged

github-actions[bot] merged 1 commit into
router-for-me:miaomiaofrom
Roomen:fix/advanced-settings-header

Conversation

@Roomen

@Roomen Roomen commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Align the Advanced Features header with the shared tabs used by Usage and Agent Configuration, removing its separate background strip and button appearance overrides.
  • Preserve category switching, search and responsive navigation; add a UI regression test comparing computed tab styles with Usage.

Validation

  • bun run check — passed.
  • bun run build — passed.
  • bun test tests/buttonControls.test.ts tests/surfaceControls.test.ts tests/choiceControls.test.ts tests/selectControls.test.tsx — 24 passed, 0 failed.
  • PLAYWRIGHT_MODULE="$(npm root -g)/playwright" node tests/config-topnav-ui.cjs — 4 scenarios passed (2 viewports × 2 locales); failed before the fix on the dedicated sticky header.
  • Visually checked browser-mock screenshots in light and sakura themes and at a narrow viewport.
  • Existing failures reproduced on the unchanged 30541c2 baseline: tests/config-settings-ui.cjs:425 (search expansion timing assertion) and tests/stateControls.test.tsx:164 (feedback-role exception list). The combined five-file unit run including state controls had 30 passed, 1 failed.
  • Not run: full unit suite, Rust tests, remaining UI tests, or native desktop visual verification.

Screenshots

Light:
Advanced Features header, light

Sakura:
Advanced Features header, sakura

Narrow viewport:
Advanced Features header, narrow

- Remove the dedicated header background and tab appearance overrides.
- Preserve search, category switching and responsive navigation.
- Add computed-style and interaction regression coverage.

Validation: bun run check; bun run build; 24 targeted unit tests; 4 UI scenarios.
@github-actions
github-actions Bot merged commit 29c53cf into router-for-me:miaomiao Oct 22, 2026
9 checks passed
@github-actions

Copy link
Copy Markdown

已自动合并并发布 Miaomiao Preview。

构建提交:29c53cf790513ef434b5774ed0f445b10691efdf

下载页为滚动预览版,后续成功构建会替换安装包。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant