Conversation
|
This pull request targeted The base branch has been automatically changed to |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b557110299
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Native host callback errors lose their numeric HTTP status when modelExecutionError returns a plain cause and when the Unix/Windows bridges serialize only err.Error(). A plugin receiving an opaque 503 cannot distinguish it from a terminal request error.
An outer StatusCode accessor can also return 0 while wrapping a valid 429/503. This occurs with the scheduler auth.WithCause/auth_unavailable wrapper, so stopping at the first errors.As match is insufficient.
Change
Review follow-up
Addressed discussion_r4021543669 in f107e67 with regressions using the real auth.WithCause wrapper and joined error trees.
Validation
Go 1.26.0, Linux ARM64, CGO enabled:
Tests cover execute/stream-start envelopes, valid/invalid status boundaries, oversized integers, fallback precedence, nested and joined causes, cancellation identity and unchanged messages. The full repository suite was not run.
A release-based equivalent was exercised with the unchanged native fallback plugin and isolated synthetic upstreams: opaque503/429 fallback,400/422 stop,primary success,output-after-failure and cancellation-after-output. The deployment-specific harness is intentionally excluded from this minimal six-file PR.