-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
fix(management): use Chrome TLS fingerprint for ChatGPT api-call #5774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HuiCheng
wants to merge
6
commits into
router-for-me:dev
Choose a base branch
from
HuiCheng:fix/management-apicall-chatgpt-chrome-tls
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0f5d801
fix(management): use Chrome TLS for ChatGPT api-call
HuiCheng 4d9de10
refactor(management): reuse shared fingerprint RoundTripper for api-call
HuiCheng 42aa81e
fix(proxyutil): support socks5h in BuildDialer
HuiCheng a2a69d2
test(helps): live SOCKS5H proof on fingerprint chrome path
HuiCheng 2c4dd4f
test(helps): keep socks5h CONNECT proof offline
HuiCheng 209e229
chore: re-attribute branch tip push to HuiCheng
HuiCheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the selected request, credential, or global proxy is
socks5h://..., this newly routes ChatGPT requests intonewUtlsRoundTripper, which passes that raw URL toproxyutil.BuildDialer. Itsproxy.FromURLpath does not recognize thesocks5hscheme, logs the setup error, and retainsproxy.Direct; consequently these ChatGPT management calls bypass the configured proxy (whereas the existingapiCallTransportexplicitly supports SOCKS5H). Normalize or handlesocks5hbefore constructing the fingerprint transport.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
proxyutil.BuildDialer(socks5/socks5h via SOCKS5 dialer, same as BuildHTTPTransport) + live proof on this branch.TestFingerprintRoundTripperSOCKS5HUsesProxy:NewFingerprintRoundTripper("socks5h://127.0.0.1:<port>", fallback)GEThttps://chatgpt.com/— local SOCKS5 listener logged domain CONNECTchatgpt.com:443(remote DNS), not Direct.Contrast
TestFingerprintRoundTripperDirectMissesSOCKS: no CONNECT on the proxy.Harness:
internal/runtime/executor/helps/fingerprint_socks5h_live_test.goCommit: 525f518
(403 without credentials is expected; the assert is proxy routing.)