Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@
pull_request:
branches:
- main
# Docs edits can't break an image build, so docs-only PRs skip it. One edge:
# deploy/sparc-service/Dockerfile COPYs that dir's README (pyproject metadata),
# so deleting it is a docs-only change that fails the build — caught by the
# push run on main, not the PR.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this edge case is better covered than the comment says. ci.yaml is unfiltered now, and its Python Tests (sparc-service) job runs pip install -e '.[dev]' in deploy/sparc-service, where pyproject.toml sets readme = "README.md" for hatchling. If that README is deleted, the editable install fails while building metadata, so the PR goes red before merge rather than only on the post-merge push run. You could reword it to something like "...still caught on the PR by ci.yaml's sparc-service job (hatchling reads it as readme)". Fine to leave as is.

# Footgun: a filtered-out run reports "Expected" forever if this workflow is
# ever added to branch protection as a required check.
paths-ignore:
- "**.md"
# Allow manual trigger
workflow_dispatch:

Expand Down Expand Up @@ -131,7 +139,7 @@
# Always use the computed tag
type=raw,value=${{ steps.tag.outputs.tag }}
# Add 'latest' tag for version tags, workflow_dispatch, and pushes to main
type=raw,value=latest,enable=${{ (github.ref_type == 'tag' && startsWith(github.ref_name, 'v')) || github.event_name == 'workflow_dispatch' || github.ref == 'refs/heads/main' }}

Check warning on line 142 in .github/workflows/build.yaml

View workflow job for this annotation

GitHub Actions / YAML Lint

142:151 [line-length] line too long (189 > 150 characters)

# 6b. Resolve per-image build-args.
# authbridge-cpex takes no CPEX FFI build-arg: its Dockerfile reads
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/security-scans.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ name: Security Scans
on:
pull_request:
branches: [main]
# Markdown cannot trip CodeQL, Trivy or Hadolint; docs-only PRs skip them.
# Footgun: a filtered-out run reports "Expected" forever if this workflow is
# ever added to branch protection as a required check.
paths-ignore:
- "**.md"

permissions: {}

Expand Down
Loading