Skip to content

fix: Declare ADD_TO_PROJECT_PAT so callers can pass only that secret #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huang195 merged 1 commit into from
Nov 3, 2026
Merged

fix: Declare ADD_TO_PROJECT_PAT so callers can pass only that secret #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/add-to-project.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: Reusable - Add to Rossoctl Project

on:
workflow_call:
# Declared so a caller can pass this one secret by name, in place of
# `secrets: inherit`, which passes every secret of the calling repo.
secrets:
ADD_TO_PROJECT_PAT:
required: false

@clawgenti clawgenti Nov 3, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: The PR description points to rossoctl/cortex#1641, which is the supply-chain tracking issue. The caller change itself is rossoctl/cortex#1649. Consider linking #1649 as well. Also, cortex calls this workflow at @main, so this PR has to merge before cortex#1649. Until it does, #1649 fails with Invalid secret, ADD_TO_PROJECT_PAT is not defined in the referenced workflow. A short note on merge order in either PR would help whoever merges them.


jobs:
add-to-project:
Expand Down
Loading