Skip to content

Security: upgrade AngleSharp for GHSA-pgww-w46g-26qg - #356

Merged
rosolko merged 1 commit into
rosolko:masterfrom
farinha:master
Jul 22, 2026
Merged

Security: upgrade AngleSharp for GHSA-pgww-w46g-26qg#356
rosolko merged 1 commit into
rosolko:masterfrom
farinha:master

Conversation

@farinha

@farinha farinha commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

This PR upgrades AngleSharp to address GitHub advisory GHSA-pgww-w46g-26qg which is a moderate-severity issue related to HTML5 parsing/spec compliance and potential mXSS sanitizer bypass behavior.

Advisory details:
Package: AngleSharp (NuGet)
Affected versions: < 1.5.0
Patched versions: >= 1.5.0
Advisory: GHSA-pgww-w46g-26qg

What changed

  • Upgraded AngleSharp to version 1.5.2
  • Added an explicit package reference to System.Text.Encoding.CodePages

Why the explicit System.Text.Encoding.CodePages reference is needed

After upgrading AngleSharp, tests that parse HTML started failing at runtime with:

FileNotFoundException for System.Text.Encoding.CodePages, Version=8.0.0.0

Adding an explicit System.Text.Encoding.CodePages reference ensures the assembly is resolved consistently during test/runtime execution for the project’s target frameworks.

Validation

Executed test suite:

dotnet test WebDriverManager.Tests.csproj -v minimal

Result:

  • Total: 74
  • Failed: 0
  • Passed: 66
  • Skipped: 8 (existing explicit skips)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Ready to approve

The change is a straightforward dependency update for a known security advisory plus a runtime dependency fix, with reported tests passing.

Note: this review does not count toward required approvals for merging.

Pull request overview

This pull request updates the WebDriverManager library’s NuGet dependencies to remediate GitHub advisory GHSA-pgww-w46g-26qg by upgrading AngleSharp to a patched version, and adds an explicit dependency needed to avoid runtime test failures after the upgrade.

Changes:

  • Upgraded AngleSharp from 1.1.2 to 1.5.2 to address GHSA-pgww-w46g-26qg.
  • Added an explicit System.Text.Encoding.CodePages package reference (8.0.0) to ensure the assembly resolves at runtime.
File summaries
File Description
WebDriverManager/WebDriverManager.csproj Bumps AngleSharp to a patched version and adds the CodePages dependency to prevent runtime FileNotFoundException after the upgrade.

Review details

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rosolko rosolko left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rosolko
rosolko merged commit 6563b31 into rosolko:master Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants