Security: upgrade AngleSharp for GHSA-pgww-w46g-26qg - #356
Merged
Conversation
There was a problem hiding this comment.
✅ Ready to approve
The change is a straightforward dependency update for a known security advisory plus a runtime dependency fix, with reported tests passing.
Note: this review does not count toward required approvals for merging.
Pull request overview
This pull request updates the WebDriverManager library’s NuGet dependencies to remediate GitHub advisory GHSA-pgww-w46g-26qg by upgrading AngleSharp to a patched version, and adds an explicit dependency needed to avoid runtime test failures after the upgrade.
Changes:
- Upgraded
AngleSharpfrom1.1.2to1.5.2to address GHSA-pgww-w46g-26qg. - Added an explicit
System.Text.Encoding.CodePagespackage reference (8.0.0) to ensure the assembly resolves at runtime.
File summaries
| File | Description |
|---|---|
| WebDriverManager/WebDriverManager.csproj | Bumps AngleSharp to a patched version and adds the CodePages dependency to prevent runtime FileNotFoundException after the upgrade. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades AngleSharp to address GitHub advisory GHSA-pgww-w46g-26qg which is a moderate-severity issue related to HTML5 parsing/spec compliance and potential mXSS sanitizer bypass behavior.
Advisory details:
Package: AngleSharp (NuGet)
Affected versions: < 1.5.0
Patched versions: >= 1.5.0
Advisory: GHSA-pgww-w46g-26qg
What changed
AngleSharpto version1.5.2System.Text.Encoding.CodePagesWhy the explicit System.Text.Encoding.CodePages reference is needed
After upgrading
AngleSharp, tests that parse HTML started failing at runtime with:FileNotFoundException for System.Text.Encoding.CodePages, Version=8.0.0.0
Adding an explicit
System.Text.Encoding.CodePagesreference ensures the assembly is resolved consistently during test/runtime execution for the project’s target frameworks.Validation
Executed test suite:
dotnet test WebDriverManager.Tests.csproj -v minimalResult: