Notify API breaks - #2086
Merged
Merged
Conversation
API breaks introduced in ros2/rclcpp#1612 Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
clalancette
requested changes
Nov 2, 2021
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
clalancette
approved these changes
Nov 2, 2021
clalancette
left a comment
clalancette
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. @wjwwood I'll let you handle merging this when you merge in ros2/rclcpp#1612
wjwwood
approved these changes
Nov 29, 2021
Member
|
I'm waiting on the GitHub actions to complete. |
mergify Bot
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Notify API breaks API breaks introduced in ros2/rclcpp#1612 Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * Address PR suggestions Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 9b74059)
mergify Bot
pushed a commit
that referenced
this pull request
Nov 29, 2021
* Notify API breaks API breaks introduced in ros2/rclcpp#1612 Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * Address PR suggestions Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 9b74059)
clalancette
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Notify API breaks API breaks introduced in ros2/rclcpp#1612 Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * Address PR suggestions Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 9b74059) Co-authored-by: mauropasse <mauropasse@hotmail.com>
clalancette
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Notify API breaks API breaks introduced in ros2/rclcpp#1612 Signed-off-by: Mauro Passerino <mpasserino@irobot.com> * Address PR suggestions Signed-off-by: Mauro Passerino <mpasserino@irobot.com> Co-authored-by: Mauro Passerino <mpasserino@irobot.com> (cherry picked from commit 9b74059) Co-authored-by: mauropasse <mauropasse@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API breaks introduced in ros2/rclcpp#1612
Signed-off-by: Mauro Passerino mpasserino@irobot.com