Skip to content

Add RMW isolation to test_launch_ros tests - #560

Open
JEnoch wants to merge 1 commit into
ros2:rollingfrom
JEnoch:fix/add_rmw_isolation
Open

Add RMW isolation to test_launch_ros tests#560
JEnoch wants to merge 1 commit into
ros2:rollingfrom
JEnoch:fix/add_rmw_isolation

Conversation

@JEnoch

@JEnoch JEnoch commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses parts of ros2/rmw_zenoh#1016

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes Claude Sonnet 5 to identify tests that require isolation.

Additional Information

Test with RMW_IMPLEMENTATION=rmw_zenoh_cpp colcon test --packages-select test_launch_ros

@mergify

mergify Bot commented Jul 29, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
@JEnoch
JEnoch force-pushed the fix/add_rmw_isolation branch from 3278e2c to ec54743 Compare July 30, 2026 09:45
@JEnoch

JEnoch commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #560
Gist: https://gist.githubusercontent.com/JEnoch/df59b458e0136b649c8878650764e02f/raw/49fbc75c9b1a7f4ca212bfb503dfd8673e79a160/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies launch_ros --cmake-args -DRMW_IMPLEMENTATION=rmw_zenoh_cpp
TEST args: --packages-above launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/20015

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@JEnoch

JEnoch commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

This should fix the only failing test from Rci__nightly-zenoh_ubuntu_resolute_amd64#93, and should be backported to lyrical for fixing test_launch_ros.pytest.missing_result failure in Lci__nightly-zenoh_ubuntu_resolute_amd64#26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants