Add RMW isolation to test_launch_ros tests - #560
Open
JEnoch wants to merge 1 commit into
Open
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: Julien Enoch <julien.e@zettascale.tech>
JEnoch
force-pushed
the
fix/add_rmw_isolation
branch
from
July 30, 2026 09:45
3278e2c to
ec54743
Compare
Contributor
Author
|
Pulls: #560 |
Contributor
Author
|
This should fix the only failing test from Rci__nightly-zenoh_ubuntu_resolute_amd64#93, and should be backported to |
cottsay
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses parts of ros2/rmw_zenoh#1016
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes Claude Sonnet 5 to identify tests that require isolation.
Additional Information
Test with
RMW_IMPLEMENTATION=rmw_zenoh_cpp colcon test --packages-select test_launch_ros